AshharAhmadKhan opened a new pull request, #5712:
URL: https://github.com/apache/fineract/pull/5712

   ## Description
   
   JIRA: https://issues.apache.org/jira/browse/FINERACT-2561
   
   The `saveAllDebitOrCreditEntries()` method was executing the same 
   organisation currency validation query inside the per-entry loop, causing 
   redundant identical database round-trips on every debit/credit line of a 
   manual journal entry request.
   
   Since `currencyCode` does not change within a single request, the validation 
   only needs to run once per method invocation — not once per loop iteration.
   
   This fix moves 
`organisationCurrencyRepository.findOneWithNotFoundDetection(currencyCode)` 
   to before the loop, consistent with the pattern already used in the same 
class 
   inside `saveAllDebitOrCreditOpeningBalanceEntries()`.
   
   No logic change — validation still happens, just once instead of N times.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to