Aman-Mittal commented on code in PR #5706:
URL: https://github.com/apache/fineract/pull/5706#discussion_r3005076792
##########
fineract-core/src/test/java/org/apache/fineract/infrastructure/core/service/IpAddressUtilsTest.java:
##########
@@ -34,14 +16,14 @@ void clearContext() {
RequestContextHolder.resetRequestAttributes();
}
- // Proper isolation helper
+ // Helper method for setting request context
private void withRequest(HttpServletRequest request, Runnable testLogic) {
ServletRequestAttributes attributes = new
ServletRequestAttributes(request);
try {
RequestContextHolder.setRequestAttributes(attributes);
testLogic.run();
} finally {
- RequestContextHolder.resetRequestAttributes(); // critical cleanup
+ RequestContextHolder.resetRequestAttributes();
Review Comment:
It Doesnt do anything. Better to revert this file change entirely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
