vidakovic commented on code in PR #5622: URL: https://github.com/apache/fineract/pull/5622#discussion_r3004051828
########## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/productmix/command/CreateProductMixCommand.java: ########## @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.portfolio.loanproduct.productmix.command; + +import lombok.Data; +import lombok.EqualsAndHashCode; +import org.apache.fineract.command.core.Command; +import org.apache.fineract.portfolio.loanproduct.productmix.data.ProductMixCommandRequest; + +@Data +@EqualsAndHashCode(callSuper = true) +public class CreateProductMixCommand extends Command<ProductMixCommandRequest> {} Review Comment: Let's be consistent with the naming of these classes: `ProductMixCreateCommand`... I know that these sounds a bit mechanic to the human ear, but the advantage here (besides consistency with already migrated modules) is that when you auto-complete code in your IDE you will immediately narrow down the list of classes whereas when you prefix with generic words like `Create`, `Update`, `Delete` you'll potentially see hundreds of classes before you see the one you intended to use. Also with this naming scheme files show up in the IDE file explorer view grouped next to each other. ########## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/productmix/command/DeleteProductMixCommand.java: ########## @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.portfolio.loanproduct.productmix.command; + +import lombok.Data; +import lombok.EqualsAndHashCode; +import org.apache.fineract.command.core.Command; +import org.apache.fineract.portfolio.loanproduct.productmix.data.ProductMixDeleteRequest; + +@Data +@EqualsAndHashCode(callSuper = true) +public class DeleteProductMixCommand extends Command<ProductMixDeleteRequest> {} Review Comment: See previous comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
