AshharAhmadKhan commented on PR #5590:
URL: https://github.com/apache/fineract/pull/5590#issuecomment-4146406922
Hey @adamsaghy, wanted to give you a quick update on what changed in this
latest push.
The previous approach for `getFixedDepositTransactions` was using
`retrieveOne20` on `FixedDepositAccountApi` to fetch transactions via the
associations param. This turned out to be unstable because the numbered suffix
is assigned globally across all API files during code generation, so it shifted
on CI and caused a compile failure (`cannot find symbol: method retrieveOne20`).
The fix was to add a proper dedicated `GET
/v1/fixeddepositaccounts/{accountId}/transactions` endpoint to
`FixedDepositAccountTransactionsApiResource` with a stable `operationId =
"retrieveAllFixedDepositAccountTransactions"`. This generates a consistently
named method on the typed client regardless of environment, and
`getFixedDepositTransactions` now calls it directly via
`fixedDepositAccountTransactions.retrieveAllFixedDepositAccountTransactions(...)`.
The swagger response class for this endpoint lives in
`FixedDepositAccountTransactionsApiResourceSwagger` alongside the existing
undo/adjust classes, which felt like the right home for it. All six of your
earlier comments on the helper are addressed in the same commit.
Could you take a look and trigger the checks when you get a chance? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
