Dishitasuyal commented on PR #5655: URL: https://github.com/apache/fineract/pull/5655#issuecomment-4144094365
Hi, I went through the PR and the implementation looks well-structured, especially the addition of the command handler and the service-level validations. I noticed that the implementation correctly handles state transitions (like preventing undo operations on inactive charges), which is great for maintaining consistency. One suggestion: it might be helpful to document the expected lifecycle of a client charge (active → inactive → restricted operations) in the API documentation or developer docs, so new contributors can better understand these constraints. Also, since this feature was previously unimplemented despite the infrastructure being present, adding a brief note in the documentation about this behavior could improve clarity. Overall, the changes look solid. Happy to help further with testing or documentation if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
