Dpk376 commented on PR #5658: URL: https://github.com/apache/fineract/pull/5658#issuecomment-4141512058
Hi @adamsaghy addressed all 3 comments: 1. Removed the no-arg constructor — fields are still needed by the remaining deprecated methods so they can't be deleted yet, but the null-initializing constructor is gone. `InstanceModeIntegrationTest` now inlines the feign calls directly. 2. Changed `getSchedulerJobIdByShortName` return type to `Long`. 3. Reverted `CallFailedRuntimeException` to use the short name with the correct import (`feign.util.CallFailedRuntimeException` which has `getStatus()`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
