adamsaghy commented on code in PR #5659:
URL: https://github.com/apache/fineract/pull/5659#discussion_r2995734853
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java:
##########
@@ -132,19 +128,19 @@ public void
whenAutoExternalIdConfigIsOnCreateClientWithValue() {
public void testClientStatusUsingExternalId() {
ClientHelper clientHelper = new ClientHelper(requestSpec,
responseSpec);
globalConfigurationHelper.manageConfigurations(GlobalConfigurationConstants.ENABLE_AUTO_GENERATED_EXTERNAL_ID,
true);
- String jsonPayload =
ClientHelper.getBasicClientAsJSON(ClientHelper.DEFAULT_OFFICE_ID,
ClientHelper.LEGALFORM_ID_PERSON, null);
- final PostClientsResponse addClientResponse =
ClientHelper.addClientAsPerson(requestSpec, responseSpec, jsonPayload);
+ final PostClientsResponse addClientResponse =
ClientHelper.addClientAsPerson(ClientHelper.DEFAULT_OFFICE_ID,
+ ClientHelper.LEGALFORM_ID_PERSON, null);
final String clientExternalId =
addClientResponse.getResourceExternalId();
final Long clientId = addClientResponse.getClientId();
assertNotNull(clientExternalId);
log.info("Client data id {} and external Id {}", clientId,
clientExternalId);
- GetClientsClientIdResponse clientResponse =
ClientHelper.getClientByExternalId(requestSpec, responseSpec, clientExternalId);
+ GetClientsClientIdResponse clientResponse =
ClientHelper.getClientByExternalId(clientExternalId);
ClientStatusChecker.verifyClientStatus(ClientStatus.ACTIVE,
clientResponse);
log.info("Client data id {} and status {}", clientExternalId,
clientResponse.getStatus().getCode());
// Close Client action
- jsonPayload = clientHelper.getCloseClientAsJSON();
+ String jsonPayload = clientHelper.getCloseClientAsJSON();
Review Comment:
WE dont need this anymore no? It should use `fineract-client` too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
