adamsaghy commented on code in PR #5554:
URL: https://github.com/apache/fineract/pull/5554#discussion_r2994879042
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/JavaType.java:
##########
@@ -343,6 +343,7 @@ public boolean isDefault(Object o) {
};
}
+ @SuppressWarnings("deprecation")
Review Comment:
Please remove the suppression... that is not fixing anything but hiding...
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/DataEnricherProcessor.java:
##########
@@ -27,13 +27,14 @@
@Component
public class DataEnricherProcessor {
- private final List<DataEnricher<?>> enhancers;
+ private final List<DataEnricher> enhancers;
@Autowired
- public DataEnricherProcessor(Optional<List<DataEnricher<?>>> enhancers) {
+ public DataEnricherProcessor(Optional<List<DataEnricher>> enhancers) {
this.enhancers = enhancers.orElse(new ArrayList<>());
}
+ @SuppressWarnings({ "unchecked", "rawtypes" })
Review Comment:
Please remove the suppression... that is not fixing anything but hiding...
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/event/external/service/InternalExternalEventService.java:
##########
@@ -108,6 +108,7 @@ private List<ExternalEventResponse>
convertToReadableFormat(List<ExternalEvent>
var payLoad = method.invoke(null, byteBuffer);
if (externalEvent.getType().equalsIgnoreCase("BulkBusinessEvent"))
{
var methodToGetDatas =
payLoad.getClass().getMethod("getDatas", (Class<?>) null);
+ @SuppressWarnings("unchecked")
Review Comment:
Please remove the suppression... that is not fixing anything but hiding...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
