Aman-Mittal commented on code in PR #19:
URL:
https://github.com/apache/fineract-backoffice-ui/pull/19#discussion_r2989556032
##########
package.json:
##########
@@ -11,9 +11,12 @@
"build:sandbox": "ng build --configuration sandbox",
"watch": "ng build --watch --configuration development",
"test": "ng test",
+ "test:e2e": "playwright test",
"lint": "ng lint",
"format": "prettier --write .",
- "format:check": "prettier --check ."
+ "format:check": "prettier --check .",
+ "generate-api": "npm run copy-swagger && npx openapi-generator-cli
generate -i ./api-spec/fineract.json -g typescript-angular -o src/app/api
--additional-properties=ngVersion=20.0.0",
Review Comment:
In generate-api need to add openApi template which automatically added
licence header during generation.
##########
e2e/login.spec.ts:
##########
@@ -0,0 +1,38 @@
+import { test, expect } from '@playwright/test';
+
+test.describe('Login', () => {
+ test('login page displays correctly', async ({ page }) => {
Review Comment:
Need to add apache 2.0 licence header here
##########
.vscode/tasks.json:
##########
@@ -0,0 +1,24 @@
+{
+ // For more information, visit:
https://go.microsoft.com/fwlink/?LinkId=733558
+ "version": "2.0.0",
Review Comment:
Need To Exclude these .vscode files as.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
