Avtansh88 opened a new pull request, #5692: URL: https://github.com/apache/fineract/pull/5692
…d using Fineract-Client ## Description Background and Motivation The PaymentTypeHelper in the integration test suite was partially using legacy RestAssured calls and manual JSON/Map handling. This approach lacked type safety and was inconsistent with the project's goal of using the OpenAPI-generated Fineract-Client. This PR aims to fully modernize the helper to ensure long-term maintainability. Changes ->Type-Safe API Calls: Refactored the retrieveById method to use the Fineract-Client (Feign) instead of legacy RestAssured and Utils.performServerGet. ->Dependency Cleanup: Removed unused RestAssured imports (RequestSpecification, ResponseSpecification) and legacy constants like PAYMENTTYPE_URL. ->Code Optimization: Replaced manual JSON parsing (Gson/TypeToken) with direct use of the PaymentTypeData model from the Fineract SDK. ->Deleted unused PaymentTypeDomain POJO to reduce technical debt. ->Spotless Formatting: Applied standard project formatting to ensure compliance with Apache Fineract coding standards. Related Issue ->Linked to Jira: [FINERACT-2554](https://www.google.com/search?q=https://issues.apache.org/jira/browse/FINERACT-2554) Tests ->Executed ./gradlew clean build -x test to verify successful compilation and spotless check. ->Verified that the modernized helper remains compatible with existing integration tests. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
