elnafateh commented on PR #5674: URL: https://github.com/apache/fineract/pull/5674#issuecomment-4107335493
> I see nothing related to the "DB-level uniqueness constraint"... there is nothing mentioning the existing idempotency solution, possible side effects with this implementation, how we should migrate from one to the other, do we have to migrate at all? Looks incomplete. Fair point — the PR description needs to be clearer. This change does not replace the existing idempotency mechanism but enhances it by providing a fallback when no idempotency key is supplied. - The DB-level uniqueness constraint remains unchanged and continues to act as the final safeguard. - No migration is required since this is backward compatible. - One trade-off is that semantically identical requests within the time window may be deduplicated unintentionally, which is a design consideration. I will update the PR description to reflect these aspects clearly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
