[
https://issues.apache.org/jira/browse/FINERACT-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067358#comment-18067358
]
Deepak Kumar S S commented on FINERACT-2549:
--------------------------------------------
Raised 4 PRs as part of this ticket:
PR #5658 — InstanceModeIntegrationTest
Migrated from RestAssured to feign. Removed @BeforeEach
boilerplate. Error cases now use assertThrows() for
CallFailedRuntimeException.
https://github.com/apache/fineract/pull/5658
PR #5659 — ClientExternalIdTest + SearchResourcesTest
+ LoanAccountsContainsCurrencyFieldTest
Migrated all 3 tests. Deleted 8 deprecated
@Deprecated(forRemoval=true) ClientHelper methods.
Responses changed from HashMap to typed feign models.
https://github.com/apache/fineract/pull/5659
PR #5668 — LoanWithdrawnByApplicantIntegrationTest
Migrated from 102 to 60 lines. Used
getResourceExternalId() for withdrawal call.
https://github.com/apache/fineract/pull/5668
PR #5670 — ClientLoanAccountLockIntegrationTest
Migrated from 134 to 65 lines. Used
FineractClientHelper.getFineractClient().legacy for
lock placement and loanAccountLockApi for retrieval.
https://github.com/apache/fineract/pull/5670
All PRs: GPG signed, CI pending first-time contributor
approval, tagged gsoc-fineract-evidence.
> Migrate integration tests from RestAssured to fineract-client-feign
> -------------------------------------------------------------------
>
> Key: FINERACT-2549
> URL: https://issues.apache.org/jira/browse/FINERACT-2549
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Deepak Kumar S S
> Priority: Minor
> Labels: gsoc-fineract-evidence
>
> Migration of InstanceModeIntegrationTest, ClientExternalIdTest,
> SearchResourcesTest, LoanAccountsContainsCurrencyFieldTest. Related to
> FINERACT-2454.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
