Dpk376 opened a new pull request, #5670: URL: https://github.com/apache/fineract/pull/5670
## Description Relates to [FINERACT-2454](https://issues.apache.org/jira/browse/FINERACT-2454) Migrates `ClientLoanAccountLockIntegrationTest` from RestAssured to the type-safe feign client. ## Changes - Replaced `RequestSpecification`/`ResponseSpecification` boilerplate with `extends BaseLoanIntegrationTest` - Removed `@BeforeEach` setup, `clientHelper`, `loanTransactionHelper`, `loanAccountLockHelper` instance fields - Replaced `ClientHelper.createClient(requestSpec, responseSpec)` → `ClientHelper.addClientAsPerson()` - Replaced `LoanProductTestBuilder` + `getLoanProductId()` → `createLoanProduct(createOnePeriod30DaysLongNoInterestPeriodicAccrualProduct())` - Replaced `LoanApplicationTestBuilder` + `getLoanId()` → `applyLoan(applyLoanRequest(...))` - Replaced `approveLoan(String, Integer)` → `approveLoan(Long, PostLoansLoanIdRequest)` - Replaced `disburseLoanWithNetDisbursalAmount()` → `disburseLoan(Long, String, Double)` - Replaced `LoanStatusChecker` HashMap assertions → `verifyLoanStatus(loanId, LoanStatus.*)` - Replaced `LoanAccountLockHelper.placeSoftLockOnLoanAccount()` (RestAssured) → `FineractClientHelper.getFineractClient().legacy.placeLockOnLoanAccount()` (feign) - Replaced `clientHelper.retrieveLockedAccounts()` instance call → `FineractClientHelper.getFineractClient().loanAccountLockApi.retrieveLockedAccounts()` (feign) ## Result 134 lines → 65 lines. Zero RestAssured imports remaining. No behavioral changes — the test still verifies that a soft-locked loan account appears in the locked accounts list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
