hms2186 commented on PR #5595: URL: https://github.com/apache/fineract/pull/5595#issuecomment-4098273265
@l0hacker @adamsaghy I have resolved the merge conflicts, applied the Spotless formatting, and added my DCO signature to the commits. The build is compiling successfully, but I noticed three E2E Cucumber tests failing (e.g., LoanChargesProgressiveLoan.feature). Since my PR standardizes Locale.ROOT string formatting, I suspect these tests are strictly matching against the old string formats. Should I go ahead and update the expected outputs in those .feature files, or are these known flaky tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
