Richard Opalka created CXF-9165:
-----------------------------------

             Summary: Remove unnecessary JDK 8 hacks
                 Key: CXF-9165
                 URL: https://issues.apache.org/jira/browse/CXF-9165
             Project: CXF
          Issue Type: Improvement
    Affects Versions: 4.0.9, 4.1.3
            Reporter: Richard Opalka


History of JDKBugHacks file in Apache CXF:
 * CXF's commit id: fea33734 , see [1]
   introduced  
common/common/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java
     was copy of 
java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
     from Tomcat's commit id: 69cd8242 , see [2]
 * CXF's commit id: f9a1e109 , see [3]
   renamed from 
common/common/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java
             to   
api/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java
 * CXF's commit id: 3dc89fe0 , see [4]
   renamed from api/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java
             to   
core/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java

Current Tomcat's JreMemoryLeakPreventionListener file contain's just 4 hacks at 
the moment, see [5].
>From those 4 hacks only first 3 of them are applicable to Apache's CXF.
Note that all JDK8 hacks have been removed (when moving to JDK9+) via these 
commit ids:
 - 424cd322 , see [6]
 - 10751cfb , see [7]
 - 1bed35d9 , see [8]

Apache CXF should synchronize its JDK hacks with Apache Tomcat JDK hacks.

[1] 
https://github.com/apache/cxf/blob/fea33734ac44761d2329b6e16370c69b49c7e68d/common/common/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java
[2] 
https://github.com/apache/tomcat/blob/69cd8242ab3bce21ba180a6dd7b279d25fa93689/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
[3] 
https://github.com/apache/cxf/commit/f9a1e109f8321f655d9e788f99b6360f67ccd452
[4] 
https://github.com/apache/cxf/commit/3dc89fe00c4e4165fc7b9c25ca0faec4ef097a87
[5] 
https://github.com/apache/tomcat/blob/473b6a70bead3fb2f6931efb4bf8eab9d539da5f/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
[6] 
https://github.com/apache/tomcat/commit/424cd322dc60f9ee63e1175e4cf957353d79b88d
[7] 
https://github.com/apache/tomcat/commit/10751cfb817c5302d6f124ed7be444a90b325b2b
[8] 
https://github.com/apache/tomcat/commit/1bed35d94b7d5322a23d35ef0e20700207d87c31



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to