GitToTheHub commented on PR #144: URL: https://github.com/apache/cordova-plugin-network-information/pull/144#issuecomment-4162674342
Thanks for the contribution and for taking the time to address the TypeScript issue. After review, we’re going to close this PR for now. The proposed typings change introduces API mismatches with this plugin’s actual runtime behavior: - `connection.type` is narrowed in a way that may reject valid values returned by the plugin. - `dispatchEvent()` is added to the typing, but this method is not implemented by the plugin object itself. So while this does address the original TS compatibility report, it also creates new type-accuracy problems. If you’d like, feel free to open a follow-up PR with a safer typing approach that keeps DOM compatibility without overstating runtime capabilities. Thanks again for your work and for raising this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
