dpogue commented on code in PR #307:
URL: https://github.com/apache/cordova-js/pull/307#discussion_r3008084023


##########
build-tools/common.js:
##########
@@ -23,12 +23,7 @@ const path = require('node:path');
 const pkgRoot = path.join(__dirname, '..');
 
 function glob (pattern, opts) {

Review Comment:
   In theory we can replace this whole `glob` function indirection with 
`fs.globSync` in all the places that use it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to