erisu opened a new pull request, #306: URL: https://github.com/apache/cordova-js/pull/306
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected n/a ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Test against the latest platform releases. ### Description <!-- Describe your changes in detail --> - Bump `cordova-android` to `15.0.0`. Uses source tarball as it contains all files needed for this test. - Bump `cordova-ios` to `8.0.1`. Uses source tarball as it contains all files needed for this test. Both packages were switched to the source tarballs, not npm package, as we need the source files from `cordova-js-src`. ### Testing <!-- Please describe in detail how you tested your changes. --> - npm t ### TODO Need to review whether the iOS `nativeFetchMessages` test is still required. It appears that the `nativeFetchMessages` method was removed from the platform's `exec.js` when UIWebView was dropped (see PR: https://github.com/apache/cordova-ios/pull/773). When UIWebView was dropped, I recall replacing the entire platform's `exec.js` file with content from [cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/src/www/ios/ios-wkwebview-exec.js). There are slight differences between the files, which most likely related to the UIWebView drop PR review. If the removal of `nativeFetchMessages` is intentional, then the test can likely be removed. Additionally, should the following code in the platform's `exec.js` also be removed? ```js execProxy.nativeFetchMessages = function () { return cordovaExec().nativeFetchMessages.apply(null, arguments); }; ``` ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
