breautek commented on PR #1903: URL: https://github.com/apache/cordova-android/pull/1903#issuecomment-4056250416
I think the proper fix is to actually use the androidx appcompat library: https://developer.android.com/reference/androidx/activity/OnBackPressedDispatcher but testing will be required to ensure it has the expected behaviour. I don't like using reflections because it makes the code harder to maintain, hide deprecation warnings, can prevent JIT optimzations and so on... In my personal experience I never really found a reason to use reflection over another solution. If the androidx is not sufficient, then it would be better to do an SDK int check to ensure we don't run API 33+ code on pre-33 devices, as the code should be compilable just not runnable, for as long as compileSdkVersion is set to 33+. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
