breautek commented on PR #1821: URL: https://github.com/apache/cordova-android/pull/1821#issuecomment-3049740455
> I'm guessing `namespace` needs the `=` because it's a property and `compileSdkVersion` doesn't because it's... not a property? And the only way to know that is to dig into gradle documentation? 😕 > > The changes seem fine to me, I just worry that now it _looks_ inconsistent and it's not going to be obvious in future changes when a `=` is needed or not (but that's Gradle's fault, not your fault) I believe `compileSdkVersion` is also deprecated in favour for `compileSdk` which is a property that you do "assign", vs `compileSdkVersion` which is actually a method, that you supply a single argument into. The Kotlin DSL is much more strict on this stuff, but is also much more streamlined/consistent. I think it will be pretty easy to migrate too, kotlin gradle I believe can still reference groovy gradle for extensions (like build-extras.gradle)... so might be worth considering doing in one of our major releases at some point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
