dpogue commented on code in PR #212:
URL: https://github.com/apache/cordova-common/pull/212#discussion_r1735881705
##########
src/ConfigChanges/ConfigFile.js:
##########
@@ -173,14 +200,26 @@ function resolveConfigFilePath (project_dir, platform,
file) {
absolute: true
}).map(path.normalize);
- if (matches.length) filepath = matches[0];
+ if (matches.length) {
+ filepath = matches[0];
+ }
- // [CB-5989] multiple Info.plist files may exist. default to
$PROJECT_NAME-Info.plist
+ // [CB-5989] multiple Info.plist files may exist. default to
Info.plist then $PROJECT_NAME-Info.plist
if (matches.length > 1 && file.includes('-Info.plist')) {
Review Comment:
There might be an issue here because we're checking if `matches.length > 1`
and if no `AppName-Info.plist` file exists then we might not have any matches,
so maybe this needs to change to `matches.length != 1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
