[
https://issues.apache.org/jira/browse/POOL-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790885#comment-16790885
]
Michael Wintermeyer commented on POOL-359:
------------------------------------------
You're right that it shows up when looking at the master branch
([https://gitbox.apache.org/repos/asf?p=commons-pool.git;a=shortlog;h=refs/heads/master]).
However, it does not show in the git log for the release branch
([https://gitbox.apache.org/repos/asf?p=commons-pool.git;a=shortlog;h=refs/heads/release])
or the tag
([https://gitbox.apache.org/repos/asf?p=commons-pool.git;a=shortlog;h=refs/tags/commons-pool-2.6.1]).
Moreover, when I go to github repo, the file has my changes on master
([https://github.com/apache/commons-pool/blob/master/src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java])
but not when I check out the file at that tag
([https://github.com/apache/commons-pool/blob/commons-pool-2.6.1/src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java]).
> NullPointerException closing multiple GenericObjectPools
> --------------------------------------------------------
>
> Key: POOL-359
> URL: https://issues.apache.org/jira/browse/POOL-359
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 2.6.0
> Reporter: Michael Wintermeyer
> Priority: Major
> Fix For: 2.6.1
>
>
> {code:java}
> java.lang.NullPointerException
> at org.apache.commons.pool2.impl.EvictionTimer.cancel(EvictionTimer.java:97)
> at
> org.apache.commons.pool2.impl.BaseGenericObjectPool.startEvictor(BaseGenericObjectPool.java:753)
> at
> org.apache.commons.pool2.impl.GenericObjectPool.close(GenericObjectPool.java:694)
> {code}
> Possible when multiple pools in the same process each call #close.
> GenericObjectPool#close checks #isClosed before proceeding, but that call
> checks a non-static instance variable. It calls into EvictionTimer#cancel
> which sets the _static_ variable EvictionCache.executor to null.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
