Partha-SUST16 commented on PR #674: URL: https://github.com/apache/commons-collections/pull/674#issuecomment-4148469148
@garydgregory I've added unit tests to demonstrate why the implementation fix is necessary rather than a Javadoc update. The implementation was not null-safe. To demonstrate that I have added 2 tests, `testRemoveNullKeyThrowsWithIdentityComparisons` and `testRemoveNullKeyThrowsWithIdentityComparisons`. Before adding the `Objects.requireNonNull(key, "key")` only the first test was passing even though the only difference between them is using `IdentityComparisons` in the second map. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
