Partha-SUST16 opened a new pull request, #675: URL: https://github.com/apache/commons-collections/pull/675
The Javadoc for `CompositeSet.addComposited(Set)` explicitly stated that a `NullPointerException` should be thrown when the `set` parameter is `null`. However, the current implementation contains a null guard ( if set != null ) that silently ignores null input and doesn't throw an exception which was reported in [COLLECTIONS_886](https://issues.apache.org/jira/browse/COLLECTIONS-886) This PR removed the NPE condition from the method as it already had test code `org.apache.commons.collections4.set.CompositeSetTest.testAddComposited` which adds null to the CompositeSet using this method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
