martin-g commented on code in PR #512:
URL: https://github.com/apache/avro-rs/pull/512#discussion_r3032122502
##########
avro/src/reader/single_object.rs:
##########
@@ -315,19 +345,26 @@ mod tests {
fn avro_rs_164_generic_reader_alternate_header() -> TestResult {
let schema_uuid =
Uuid::parse_str("b2f1cf00-0434-013e-439a-125eb8485a5f")?;
let header_builder = GlueSchemaUuidHeader::from_uuid(schema_uuid);
- let generic_reader =
GenericSingleObjectReader::new_with_header_builder(
- TestSingleObjectReader::get_schema(),
- header_builder,
- )
- .expect("failed to build reader");
+ let generic_reader = GenericSingleObjectReader::builder()
+ .schema(TestSingleObjectReader::get_schema())
+ .header(header_builder.build_header())
+ .build()
+ .expect("failed to build reader");
+ // First 18 bytes are the header, than it's a varint 0, double 0 and
an empty list (0)
Review Comment:
```suggestion
// First 18 bytes are the header, then it's a varint 0, double 0 and
an empty list (0)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
