gszadovszky commented on code in PR #3693:
URL: https://github.com/apache/avro/pull/3693#discussion_r3009671460
##########
lang/java/avro/src/main/java/org/apache/avro/io/FastReaderBuilder.java:
##########
@@ -446,8 +447,8 @@ private FieldReader getTransformingStringReader(String
valueClass, FieldReader s
private Optional<Class<?>> findClass(String clazz) {
try {
- return Optional.of(data.getClassLoader().loadClass(clazz));
- } catch (ReflectiveOperationException e) {
+ return Optional.of(ClassUtils.forName(data.getClassLoader(), clazz));
+ } catch (ClassNotFoundException | SecurityException e) {
Review Comment:
I'm wondering if it is a good practice here to swallow the
`SecurityException`. It will be hard to analyze why the class loading is not
working while the `SecurityException` contains a comprehensive explanation.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
