Kriskras99 commented on PR #514:
URL: https://github.com/apache/avro-rs/pull/514#issuecomment-4127294105
I can't reproduce getting `#[inline]` suggestions, I ran Clippy with the
following command:
`cargo clippy --all-features --all-targets -- -W clippy::pedantic -W
clippy::all -W clippy::cargo -W clippy::nursery` and I get the following lints
triggered:
- `clippy::ignored_unit_patterns`
- `clippy::semicolon_if_nothing_returned`
- `clippy::unnecessary_wraps`
- `clippy::default_trait_access`
- `clippy::redundant_closure_for_method_calls`
- `clippy::needless_pass_by_value`
- `clippy::cast_lossless`
- `clippy::too_many_lines`
- `clippy::cast_possible_truncation`
- `clippy::items_after_statements`
- `clippy::explicit_into_iter_loop`
- `clippy::implicit_clone`
- `clippy::ref_option_ref`
- `clippy::unnecessary_semicolon`
- `clippy::explicit_iter_loop`
- `clippy::manual_let_else`
- `clippy::used_underscore_binding`
- `clippy::manual_string_new`
- `clippy::match_same_arms`
- `clippy::inline_always`
- `clippy::needless_raw_string_hashes`
- `clippy::unreadable_literal`
- `clippy::unnecessary_debug_formatting`
- `clippy::if_not_else`
- `clippy::similar_names`
- `clippy::uninlined_format_args`
- `clippy::cast_precision_loss`
- `clippy::redundant_else`
- `clippy::must_use_candidate`
- `clippy::elidable_lifetime_names`
- `clippy::missing_errors_doc`
- `clippy::missing_panics_doc`
- `clippy::borrow_as_ptr`
- `clippy::struct_field_names`
- `clippy::cast_possible_wrap`
- `clippy::cast_sign_loss`
- `clippy::ref_option`
- `clippy::map_unwrap_or`
- `clippy::ref_binding_to_reference`
- `clippy::checked_conversions`
- `clippy::implicit_hasher`
- `clippy::collapsible_match`
- `clippy::single_match_else`
- `clippy::enum_glob_use`
- `clippy::explicit_deref_methods `
- `clippy::unnecessary_trailing_comma`
- `clippy::needless_for_each`
- `clippy::unnecessary_join`
- `clippy::stable_sort_primitive`
- `clippy::missing_fields_in_debug`
- `clippy::flat_map_option`
- `clippy::unused_self`
- `clippy::inconsistent_struct_constructor`
- `clippy::trivially_copy_pass_by_ref`
- `clippy::unnested_or_patterns`
- `clippy::needless_continue`
- `clippy::struct_excessive_bools`
- `clippy::manual_assert`
- `clippy::use_self`
- `clippy::iter_on_single_items`
- `clippy::redundant_clone`
- `clippy::equatable_if_let`
- `clippy::option_if_let_else`
- `clippy::missing_const_for_fn`
- `clippy::derive_partial_eq_without_eq`
- `clippy::string_lit_as_bytes`
- `clippy::fallible_impl_from`
- `clippy::clear_with_drain`
- `clippy::redundant_pub_crate`
- `clippy::needless_collect`
- `clippy::nonstandard_macro_braces`
- `clippy::needless_pass_by_ref_mut `
- `clippy::collapsible_match`
- `clippy::or_fun_call`
- `clippy::future_not_send`
- `clippy::single_option_map`
- `clippy::multiple_crate_versions
Which lint triggered your `#[inline]` suggestions? The only lint I can find
in the Clippy database is
[`missing_inline_in_public_items`](https://rust-lang.github.io/rust-clippy/stable/index.html?search=inline#missing_inline_in_public_items),
but that is a `restriction` lint which is a group that should not be enabled
by default (see
[`blanket_clippy_restriction_lints`](https://rust-lang.github.io/rust-clippy/master/index.html#blanket_clippy_restriction_lints))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
