gemmellr commented on PR #6228: URL: https://github.com/apache/artemis/pull/6228#issuecomment-4055667696
I did look into the caching bit, and came up with a change that mostly handles it (not quite perfectly, there are a few poms that still need downloaded for older errorprone bits, due to the needs of dependency resolution..will look into avoiding that another time). I pushed the commit up to my fork at https://github.com/gemmellr/artemis/commits/refs/heads/jbertram-ARTEMIS-5896/, along with a rebase of yours where I just removed the versions.adoc changes due to all the conflicts now present. If you like the added change I could push them here, or you can pull them into your branch. Happy just to squash them on final merge either way. Thinking about it, I think it may actually make sense just to omit the versions.adoc changes. It is after all the user-manual rather developer manual. With the Jira now more detailed about the change, there is also now a specific release note of the behaviour change unlike originally. What do you think? (I also found an unrelated existing cache priming issue from the TLP switch that I fixed on main in https://github.com/apache/artemis/commit/47b0efb43a5f0564808744e2a0aaafc00ef10c61) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
