jbertram commented on PR #6278: URL: https://github.com/apache/artemis/pull/6278#issuecomment-4040056300
@hyperxpro, this looks good overall. Nice work! That said, there are a few items that need attention: 1. The commit message should reference the Jira. See [here](https://artemis.apache.org/components/artemis/documentation/hacking-guide/#commitMessageDetails). 2. There is no test that verifies the behavior. I think even a simple unit test that verifies `broadcast` is `null` or not when creating an instance of `ManagementServiceImpl` would be sufficient. 3. I realize now that using the term "mirrors" in Jira description was a mistake because we already have a mirroring feature in the broker and this may cause confusion. You've used this term throughout the JavaDoc and commit message. I think using something like "reproduces" (and variants) would be more clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
