rok opened a new issue, #50636:
URL: https://github.com/apache/arrow/issues/50636

   ### Describe the bug, including details regarding any error messages, 
version, and platform.
   
   The `test-r-macos-as-cran` crossbow job fails when compiling 
`vector_sort.cc` against the macOS 11.3 SDK:
   
   > error: cannot convert initializer list argument to 'std::span<uint64_t>'
   
   This was introduced in #50248 
https://github.com/apache/arrow/blob/bc9d1349e091dead2044ed200d3e3e867578b354/cpp/src/arrow/compute/kernels/vector_sort.cc#L234-L248
   
   The macOS 11.3 libc++ implementation uses __wrap_iter for span iterators but 
only accepts raw pointers in this constructor. Using indices.data() for the 
internal range iteration, or constructing the range with subspan(), would 
likely retain the span interface and fix the issue.
   
   ```diff
    diff --git a/cpp/src/arrow/compute/kernels/vector_sort.cc 
b/cpp/src/arrow/compute/kernels/vector_sort.cc
   -  auto range_start = indices.begin();
   +  auto range_start = indices.data();
      auto range_cur = range_start;
   +  const auto range_end = range_start + indices.size();
      auto last_value = GetView::LogicalValue(array.GetView(*range_cur - 
offset));
   -  while (++range_cur != indices.end()) {
   +  while (++range_cur != range_end) {
   ```
   
   Crossbow failure:
   
https://github.com/ursacomputing/crossbow/actions/runs/30154135424/job/89669316217#step:9:2303
   
   ### Component(s)
   
   C++, R


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to