pitrou opened a new issue, #50596: URL: https://github.com/apache/arrow/issues/50596
### Describe the enhancement requested The `ArrayBuilder::AppendScalar` implementation is currently very odd: * the `ArrayBuilder` hierarchy uses polymorphism (i.e. virtual methods) to handle type-specific operations * but `ArrayBuilder::AppendScalar` is implemented entirely in the base class using a visitor, putting type-specific knowledge in the base class definition * but `ArrayBuilder::AppendScalar` is *also* a virtual method overriden in dictionary and run-end-encoded builders * furthermore, the visitor in the base class definition of `ArrayBuilder::AppendScalar` dispatched on the scalar's data type, instead of the builder's data type We should refactor the `AppendScalar` implementation to be entirely polymorphic and remove any trace of type-specific implementations in the base class (`ArrayBuilder::AppendScalar` would probably become a pure virtual method). This would also help in cases like https://github.com/apache/arrow/pull/50584 ### Component(s) C++ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
