kou opened a new issue, #49752:
URL: https://github.com/apache/arrow/issues/49752

   ### Describe the bug, including details regarding any error messages, 
version, and platform.
   
   1: `gdv_hash_using_openssl()` is an internal function but it's exported:
   
   
https://github.com/apache/arrow/blob/4eca50770f7f2c5938a676f0719fbfc8aae4803c/cpp/src/gandiva/hash_utils.cc#L66-L69
   
   2: If one of invalid digest size check and result buffer size check returns 
false, `gdv_hash_using_openssl()` should report an error. But 
`gdv_hash_using_openssl()` reports an error only when both of them return 
false: 
   
   
https://github.com/apache/arrow/blob/4eca50770f7f2c5938a676f0719fbfc8aae4803c/cpp/src/gandiva/hash_utils.cc#L105-L113
   
   3: Buffer size specified to `snprintf()` is wrong. `result_buf_size` should 
be `result_buf_size - result_buff_index`.
   
   
https://github.com/apache/arrow/blob/4eca50770f7f2c5938a676f0719fbfc8aae4803c/cpp/src/gandiva/hash_utils.cc#L129-L136
   
   ### Component(s)
   
   C++, Gandiva


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to