zanmato1984 opened a new issue, #48268:
URL: https://github.com/apache/arrow/issues/48268

   ### Describe the enhancement requested
   
   Currently the supported type of residual filter expression is different 
between our two hash join implementations:
   The `HashJoin` is assuming only boolean type, which is appropriate 
https://github.com/apache/arrow/blob/79d645877e65fd892d662c40b77cfe788bec6a96/cpp/src/arrow/acero/hash_join.cc#L309
   The `SwissJoin` is more tolerant by exceptionally allowing a null type 
`null` (not the boolean type null), which I think is a mistake I made in #39487 
https://github.com/apache/arrow/blob/79d645877e65fd892d662c40b77cfe788bec6a96/cpp/src/arrow/acero/swiss_join.cc#L1928
   
   The current CI contains a test that explicitly exercises null type null, 
which is also to be revised: 
https://github.com/apache/arrow/blob/79d645877e65fd892d662c40b77cfe788bec6a96/cpp/src/arrow/acero/hash_join_node_test.cc#L2102
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to