pitrou opened a new issue, #47953:
URL: https://github.com/apache/arrow/issues/47953

   ### Describe the bug, including details regarding any error messages, 
version, and platform.
   
   In `int_util_overflow.h` we're currently including (indirectly) some Windows 
header through `windows_compatibility.h`:
   
https://github.com/apache/arrow/blob/f669b9fb6b71e74bb41496252709b494233de44d/cpp/src/arrow/util/int_util_overflow.h#L28-L33
   
   This was probably necessary when this was initially committed, but can 
produce problems when expanding the use of this header in our codebase, due to 
unwanted macro definitions, here is an 
[example](https://github.com/apache/arrow/actions/runs/18754865884/job/53504089972?pr=47925):
   ```
   D:/a/arrow/arrow/cpp/src/parquet/arrow/schema.cc:78:45: error: expected 
unqualified-id
      78 |   return is_nullable ? Repetition::OPTIONAL : Repetition::REQUIRED;
         |                                             ^
   D:/a/arrow/arrow/cpp/src/parquet/arrow/schema.cc:331:45: error: expected 
unqualified-id
     331 |       if (repetition != Repetition::OPTIONAL) {
         |                                             ^
   2 errors generated.
   ```
   
   
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to