zdt7ilm opened a new issue, #47774:
URL: https://github.com/apache/arrow/issues/47774
### Describe the enhancement requested
I use apache arrow to read some parquets (tpch lineitem table, about
25millon rows),
observed hotspot on ~Status() method by intel Vtune,
then I try to inline it use ARROW_FORCE_INLINE, **faster 15% stably**
before:
` ~Status() noexcept {
if (ARROW_PREDICT_FALSE(state_ != NULL)) {
if (!state_->is_constant) {
DeleteState();
}
}
}`
after:
` ARROW_FORCE_INLINE ~Status() noexcept {
if (ARROW_PREDICT_FALSE(state_ != NULL)) {
if (!state_->is_constant) {
DeleteState();
}
}
}`
so, is this a suitable optimization in all cases? any problems with it?
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
