paleolimbot opened a new issue, #796: URL: https://github.com/apache/arrow-nanoarrow/issues/796
In https://github.com/microsoft/vcpkg/pull/46029 I tried to add the IPC feature but it doesn't quite work because - the vcpkg version is at 0.6.1, which is the last "release" but is also too old for us (if I remember correctly we need a newer version because of the verify code) - Finding flatcc isn't quite supported because flatcc doesn't provide cmake or pkgconfig. We can almost certainly use `find_library()` or the installed directory for this. ```cmake set(NANOARROW_IPC_OPTION OFF) set(NANOARROW_FLATCC_ROOT_DIR_OPTION "") if("ipc" IN_LIST FEATURES) set(NANOARROW_IPC_OPTION "-DNANOARROW_IPC=ON") set(NANOARROW_FLATCC_ROOT_DIR_OPTION = "-DNANOARROW_FLATCC_ROOT_DIR=${CURRENT_INSTALLED_DIR}") endif() vcpkg_cmake_configure( SOURCE_PATH "${SOURCE_PATH}" OPTIONS -DNANOARROW_INSTALL_SHARED=${NANOARROW_INSTALL_SHARED} -DNANOARROW_DEBUG_EXTRA_WARNINGS=OFF ${NANOARROW_IPC_OPTION} ${NANOARROW_FLATCC_ROOT_DIR_OPTION} ) ``` I also found that setting the LIB_DIR option for flatcc doesn't quite work (unsurprising because we never test it!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@arrow.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
