[I] JDBC adapter query Postgres numeric field error: Cannot get simple type for type DECIMAL [arrow-adbc]

[via GitHub]

RealDeanZhao opened a new issue, #2297:
URL: https://github.com/apache/arrow-adbc/issues/2297

   ### What happened?
   
   JDBC adapter query Postgres numeric field error: Cannot get simple type for 
type DECIMAL
   
   ### Stack Trace
   
    Invalid Input Error: arrow_scan: get_next failed(): 
java.lang.RuntimeException: Error occurred while getting next schema root.
        at 
org.apache.arrow.adapter.jdbc.ArrowVectorIterator.next(ArrowVectorIterator.java:190)
        at 
org.apache.arrow.adbc.driver.jdbc.JdbcArrowReader.loadNextBatch(JdbcArrowReader.java:87)
        at 
org.apache.arrow.c.ArrayStreamExporter$ExportedArrayStreamPrivateData.getNext(ArrayStreamExporter.java:66)
   Caused by: java.lang.RuntimeException: Error occurred while consuming data.
        at 
org.apache.arrow.adapter.jdbc.ArrowVectorIterator.consumeData(ArrowVectorIterator.java:112)
        at 
org.apache.arrow.adapter.jdbc.ArrowVectorIterator.load(ArrowVectorIterator.java:163)
        at 
org.apache.arrow.adapter.jdbc.ArrowVectorIterator.next(ArrowVectorIterator.java:183)
        ... 2 more
   Caused by: java.lang.UnsupportedOperationException: Cannot get simple type 
for type DECIMAL
        at org.apache.arrow.vector.types.Types$MinorType.getType(Types.java:815)
        at 
org.apache.arrow.adapter.jdbc.consumer.CompositeJdbcConsumer.consume(CompositeJdbcConsumer.java:49)
        at 
org.apache.arrow.adapter.jdbc.ArrowVectorIterator.consumeData(ArrowVectorIterator.java:98)
        ... 4 more
   À
   
   ### How can we reproduce the bug?
   
   Numeric field without scale and precision with cause the error
   ```sql
   create table  xxx (
    numeric_a numeric
   )
   ```
   
   Also tried debug the code and found  pg jdbc driver getBigDecimal will 
return a BigDecimal with precision 1. This will cause the actual error: 
"BigDecimal precision cannot be greater than that in the Arrow vector'
   ```java
   public void consume(ResultSet resultSet) throws SQLException {
   // value's scale is 0 and precision is 1, this will cause the error
               BigDecimal value = 
resultSet.getBigDecimal(this.columnIndexInResultSet);
               if (!resultSet.wasNull()) {
                   this.set(value);
               }
   
               ++this.currentIndex;
           }
   ```
   
   ```java
    public static boolean checkPrecisionAndScale(BigDecimal value, int 
vectorPrecision, int vectorScale) {
           int var10002;
           if (value.scale() != vectorScale) {
               var10002 = value.scale();
               throw new UnsupportedOperationException("BigDecimal scale must 
equal that in the Arrow vector: " + var10002 + " != " + vectorScale);
           } else if (value.precision() > vectorPrecision) {
   // value precision is 1 and vector precision is 0 
               var10002 = value.precision();
               throw new UnsupportedOperationException("BigDecimal precision 
cannot be greater than that in the Arrow vector: " + var10002 + " > " + 
vectorPrecision);
           } else {
               return true;
           }
       }
   ```
   
   
   ### Environment/Setup
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org