tokoko opened a new issue, #2241:
URL: https://github.com/apache/arrow-adbc/issues/2241

   ### What happened?
   
   Driver trait has two methods `new_database` and `new_database_with_opts`, 
but `new_database` is always ignored by ManagedDriver. instead of forwarding 
the call to the inner driver's `new_database` method, it invokes 
`new_database_with_opts(None)`.
   
   This is almost always desirable behavior, but it can be confusing when 
you're getting `not yet implemented` error calling `new_database` even if you 
have `new_database` implemented.
   
   P.S. pretty sure the same applies to other objects as well (Database, 
Connection..)
   
   ### Stack Trace
   
   _No response_
   
   ### How can we reproduce the bug?
   
   This fails if `new_database_with_opts` is not implemented.
   
   ```
   let mut driver = ManagedDriver::load_dynamic_from_name(
           "adbc_dummy",
           Some(b"DummyDriverInit"),
           AdbcVersion::V110,
       ).unwrap();
   
   let mut database = driver.new_database().unwrap();
   ```
   
   ### Environment/Setup
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to