[I] missing methods for `fromarrow(::Type{Time}, x::Arrow.Time{<:Arrow.Flatbuf.TimeUnit.T, <:Integer})` [arrow-julia]

[via GitHub]

palday opened a new issue, #526:
URL: https://github.com/apache/arrow-julia/issues/526

   I did not create table in question, but the column in question contains a 
time stored as `Arrow.Time{Arrow.Flatbuf.TimeUnit.MICROSECOND, Int64}` which 
errors upon access.
   
   This can be fixed by adding the methods
   
   ```julia
   function fromarrow(::Type{Time}, 
x::Arrow.Time{Arrow.Flatbuf.TimeUnit.MICROSECOND, <:Integer})
      return Time(0, 0, 0) + Microsecond(x.x)
   end
   
   function fromarrow(::Type{Time}, 
x::Arrow.Time{Arrow.Flatbuf.TimeUnit.MILLISECOND, <:Integer})
       return Time(0, 0, 0) + Millisecond(x.x)
    end
   
    function fromarrow(::Type{Time}, 
x::Arrow.Time{Arrow.Flatbuf.TimeUnit.NANOSECOND, <:Integer})
       return Time(0, 0, 0) + Nanosecond(x.x)
    end
   
    function fromarrow(::Type{Time}, 
x::Arrow.Time{Arrow.Flatbuf.TimeUnit.SECOND, <:Integer})
       return Time(0, 0, 0) + Second(x.x)
    end
   ```
   
   I can open a PR adding these methods if there is no other preferred solution


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org