kou opened a new issue, #43796: URL: https://github.com/apache/arrow/issues/43796
### Describe the enhancement requested We don't indent in preprocessor directives now. For example: https://github.com/apache/arrow/blob/bad064f705ec9fc72efac2d13a1fc3fac6d3d137/cpp/src/arrow/util/visibility.h#L20-L27 If we indent preprocessor directives, it improves readability: ```cpp #if defined(_WIN32) || defined(__CYGWIN__) // Windows # if defined(_MSC_VER) # pragma warning(disable : 4251) # else # pragma GCC diagnostic ignored "-Wattributes" # endif ``` FYI: Google C++ style guide doesn't require indent in preprocessor directives nor deny it: https://google.github.io/styleguide/cppguide.html#Preprocessor_Directives ```cpp // Good - directives at beginning of line if (lopsided_score) { #if DISASTER_PENDING // Correct -- Starts at beginning of line DropEverything(); # if NOTIFY // OK but not required -- Spaces after # NotifyClient(); # endif #endif BackToNormal(); } ``` ### Component(s) C++ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@arrow.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
