[
https://issues.apache.org/jira/browse/ISIS-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459674#comment-13459674
]
Dan Haywood commented on ISIS-264:
----------------------------------
Patch applied, thanks.
A few fixes/clarifications (that I've made):
* the FallbackFacetFactory will always end up installing a PagedFacet if there
is no @Paged annotation (agreed offline). There's therefore no need for
default handling for the PagedAnnotationOnXxxFacetFactory ... may as well
insist that value() is mandatory after all
* in PagedAnnotationOnTypeFacetFactory, the processMethod() call is redundant
... it will never be called. Have removed.
* ditto, in PagedAnnotationOnCollectionFacetFactory, the processClass() call is
redundant ... it will never be called. Have removed.
* the @Paged annotation is not required on the above FacetFactory impls
* in the FallbackFacetFactory where do getConfiguration().getInteger(...), have
provided a default value in case there is none in the isis.properties
(otherwise would be value zero).
* typo in isis-applib.xml
> Add @Paged annotation (for use by viewer-side paging as a minimum).
> Implement in Wicket as a minimum
> -----------------------------------------------------------------------------------------------------
>
> Key: ISIS-264
> URL: https://issues.apache.org/jira/browse/ISIS-264
> Project: Isis
> Issue Type: New Feature
> Components: Core: MetaModel, Core: ProgModel, Viewer: Wicket
> Affects Versions: 0.2.0-incubating
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Minor
> Fix For: 0.3.1-incubating
>
> Attachments: patch.diff
>
>
> @Paged(25) on the type indicates the page size for standalone collections.
> @Paged(12) on a collection indicates the page size for parented collections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
