Hi Geert-san, Thank you for your review!
> From: Geert Uytterhoeven, Sent: Wednesday, February 2, 2022 6:24 PM > > Hi Shimoda-san, > > On Tue, Jan 25, 2022 at 6:36 PM Yoshihiro Shimoda > <[email protected]> wrote: > > Add support for R-Car Gen4 like r8a779f0 (R-Car S4-8). The IPMMU > > hardware design of r8a779f0 is the same as r8a779a0. So, rename > > "r8a779a0" to "rcar_gen4". > > > > Signed-off-by: Yoshihiro Shimoda <[email protected]> > > Thanks for your patch! > > > --- a/drivers/iommu/ipmmu-vmsa.c > > +++ b/drivers/iommu/ipmmu-vmsa.c > > > @@ -743,7 +744,7 @@ static bool ipmmu_device_is_allowed(struct device *dev) > > unsigned int i; > > > > /* > > - * R-Car Gen3 and RZ/G2 use the allow list to opt-in devices. > > + * R-Car Gen3, Gen4 and RZ/G2 use the allow list to opt-in devices. > > * For Other SoCs, this returns true anyway. > > */ > > if (!soc_device_match(soc_needs_opt_in)) > > There are a few more references to "Gen3" that can be extended. I'm afraid, but I could not understand this mean. Best regards, Yoshihiro Shimoda > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > [email protected] > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
