On 1/24/22 5:29 PM, Christoph Hellwig wrote:
On Mon, Jan 24, 2022 at 03:11:00PM +0800, Lu Baolu wrote:
The supported page sizes of an iommu_domain are saved in the pgsize_bitmap
field. Retrieve the value from the right place.
Signed-off-by: Lu Baolu <[email protected]>
Reviewed-by: Robin Murphy <[email protected]>
Link:
https://lore.kernel.org/r/[email protected]
Looks good:
Reviewed-by: Christoph Hellwig <[email protected]>
Wouldn't it mke sense to remove the pgsize_bitmap in struct iommu_ops
and initialize the domain field in the domain_alloc methods? Or am I
missing something?
It looks reasonable to me. The pgsize_bitmap is an attribute of a domain
that provides the map/unmap interfaces. It could be moved out of the
iommu_ops structure.
Best regards,
baolu
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
