Il 11/01/22 07:39, Yong Wu ha scritto:
The successful return value for clk_bulk_prepare_enable is 0, rather than "< 0". Fix this.
Hello! Thanks for this commit! However, there are a few comments... This description is a bit confusing, please reword it, something like... "Function clk_bulk_prepare_enable() returns 0 for success or a negative number for error. Fix this code style issue." In any case, you're not fixing any bad logic issue here, as the function will never return anything > 0. What you're fixing is a common pattern usage issue, so the Fixes tag can be removed since it's not really useful to schedule this commit for backport over older stable versions. After the requested changes: Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
Fixes: 0e14917c57f9 ("memory: mtk-smi: Use clk_bulk clock ops") Signed-off-by: Yong Wu <[email protected]> --- drivers/memory/mtk-smi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c index b883dcc0bbfa..e7b1a22b12ea 100644 --- a/drivers/memory/mtk-smi.c +++ b/drivers/memory/mtk-smi.c @@ -480,7 +480,7 @@ static int __maybe_unused mtk_smi_larb_resume(struct device *dev) int ret;ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb->smi.clks);- if (ret < 0) + if (ret) return ret;/* Configure the basic setting for this larb */
_______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
