Hi Miaoqian,
On 1/7/22 2:04 AM, Miaoqian Lin wrote:
> The reference taken by 'of_find_device_by_node()' must be released when
> not needed anymore.
Thanks for catching this.
> Add the corresponding 'put_device()' in the error handling paths.
Also, need it in the regular path, not just in error handling path.
>
> Fixes: ede1c2e7d4dc ("iommu/omap: Store iommu_dev pointer in arch_data")
> Signed-off-by: Miaoqian Lin <[email protected]>
> ---
> drivers/iommu/omap-iommu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index 91749654fd49..cbc7ca5e890a 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -1684,6 +1684,7 @@ static struct iommu_device
> *omap_iommu_probe_device(struct device *dev)
> oiommu = platform_get_drvdata(pdev);
> if (!oiommu) {
> of_node_put(np);
> + put_device(&pdev->dev);
nit, doesn't matter for functionality, but prefer the put_device before
of_node_put().
regards
Suman
> kfree(arch_data);
> return ERR_PTR(-EINVAL);
> }
>
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
