On Tue, Apr 29, 2014 at 6:22 PM, Will Deacon <[email protected]> wrote: > On Sat, Apr 26, 2014 at 03:28:37PM +0100, Ritesh Harjani wrote: >> Hi Guys, >> >> Need again some help in deciding which all functions/Data structures >> needs to be moved out from arch/arm/mm/dma-mapping to >> lib/iommu-helper.c. >> >> 1. There is this dma_iommu_mapping structure defination in >> arch/arm/include/asm/dma-iommu.h. In arm this structure is declared as >> "mapping" which is part of dev_archdata structure, which is used for >> IOVA management. >> Now, does this make sense to move this structure out to >> include/linux/iommu-helper.h ? And define a config like >> CONFIG_IOMMU_USE_HELPER_MAPPING (default n) which will be used to, >> have a variable("mapping") defined or not in dev_archdata of all >> archs. > > In that case, wouldn't it make more sense to put the DMA mapping information > in the struct device itself, rather than the dev_archdata? The CMA data, for > example, is stored directly there.
Yes, thanks for pointing out. So, we will have mapping variable put in device structure. Will, So, you think option 1 should be carried out ? This way we can decouple arch specific things in arch/arm/mm/dma-mapping and other stuff like IOVA management and buffer management in lib/iommu-helper.c (thats what lib/swiotlb does too). Only thing to note here is that, we will have only ARM as the current user of this helper functions. Once this refactoring is done, later we can modify the lib/iommu-helper.c functions to make more sense for other archs as well. My only concern here was that whether we can take out this dma_iommu_mapping structure. Because currently all archs have their own way of implementing IOVA management and buffer allocation, but as in some mail chain it was pointed out that as when the need arises other arch can modify iommu-helper to suit their needs too. > > Will Marek/Catalin, Could you guys also comment on this please. If we agree on this (option 1), then I can take it from there and refactoring should be fairly straight forward. Thanks Ritesh _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
