On Fri, Aug 16, 2013 at 11:20:16AM -0600, Shuah Khan wrote:
> +DEFINE_EVENT(iommu_fault, report_fault,
> +
> +     TP_PROTO(struct device *dev, unsigned long iova, int flags),
> +
> +     TP_ARGS(dev, iova, flags)
> +);

I am not entirely happy with the naming. It is better to name the class
iommu_error and the page-fault event io_page_fault. This makes it more
clear what kind of fault it is.


        Joerg


_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to