Am 10.04.2026 um 17:40 schrieb Derick Rethans <[email protected]>:
> On 10 April 2026 15:21:34 BST, Christian Schneider <[email protected]>
> wrote:
>> Am 10.04.2026 um 12:54 schrieb Gina P. Banyard <[email protected]>:
>>> On Thursday, 9 April 2026 at 14:33, Christian Schneider
>>> <[email protected]> wrote:
>>>> The implementation can be examined at
>>>> https://github.com/php/php-src/compare/master...chschneider:php-src:internal-functions-doccomments
>>>
>>> I am not *fully* convinced that we should add DocComments for internal
>>> parameters/functions/classes/constants, as this feels like a lot of
>>> complexity.
>>
>> What kind of complexity are you thinking about? Code-wise? Integration into
>> the build process?
>
> I'm wondering how much this does to increase the size of the PHP compiled
> binaries.
On my machine it adds about 2M (7%) as the sapi/cli/php binary increases from
~28M to ~30M for a build with default ./configure and
CFLAGS="-O3 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64"
I would assume this is mostly in a read-only data section and hence shareable
between processes.
- Chris
