Hi,

>Don't use QStringLiteral with QRegExp, specially in plugins you'll 
>unload.
>See https://blogs.kde.org/2015/11/05/qregexp-qstringliteral-crash-exit

The backtrace there certainly looks familiar. The mentioned fix (in 5.6) was to 
stop unloading plugins, a principle that's clearly not being applied here. I'm 
running Qt 5.9.3 here, and am *almost* certain I never saw the issue in 5.8.0 
(but have yet to compare the relevant qfactory*.cpp files).

What bothers me here is that the explanation suggests that it doesn't matter if 
you do `QRegExp(QStringLiteral("foo"))` or if there are 27 intermediate 
variables and function arguments between the QRegExp and the QStringLiteral. I 
hope that's me misunderstanding because otherwise we almost have to drop the 
NO_CAST_FROM_ASCII build option; KIO use a *lot* of QRegExp instances I 
noticed, and the code is evidently littered with QStringLiterals.

R.
_______________________________________________
Interest mailing list
Interest@qt-project.org
http://lists.qt-project.org/mailman/listinfo/interest

Reply via email to