Re: [Interest] Compilation of Qt 5.2 winextras fails on Windows

[Jürgen Hunold]

On Monday, 6. January 2014 08:37:55 Adam Light wrote:
> Hi
> 
> I am trying to build my own version of Qt 5.2 from a Git checkout, but I'm
> getting compiler errors in the winextras module.

> If I re-run configure and add the "-skip winextras" parameters, and then
> run jom again, I am able to build successfully.
> 
> The combination of Windows 7 and MSVC 2008 is not listed as supported at
> http://qt-project.org/doc/qt-5/supported-platforms.html. Has anyone else
> run into this problem?

Yes, this seems to be broken. The attached patch comments out the broken code 
and shows where to look closer. 
Please file a bug report.

Yours,

Jürgen
-- 
* Dipl.-Math. Jürgen Hunold  ! 
* voice: ++49 4257 300       ! Fährstraße 1
* fax  : ++49 4257 300       ! 31609 Balge/Sebbenhausen
* jhun...@gmx.eu             ! Germany
Index: qtwinextras/src/winextras/qwinjumplistcategory.cpp
===================================================================
--- qtwinextras/src/winextras/qwinjumplistcategory.cpp	(revision 1785)
+++ qtwinextras/src/winextras/qwinjumplistcategory.cpp	(working copy)
@@ -126,7 +126,7 @@
     Q_ASSERT(item->type() == QWinJumpListItem::Link);
     const QString identifier = jumpList ? jumpList->identifier() : QString();
     wchar_t *id = qt_qstringToNullTerminated(identifier);
-
+#if 0
     SHARDAPPIDINFOLINK info;
     info.pszAppID = id;
     info.psl =  QWinJumpListPrivate::toIShellLink(item);
@@ -135,6 +135,7 @@
         info.psl->Release();
     }
     delete[] id;
+#endif
 }
 
 void QWinJumpListCategoryPrivate::clearRecents()
Index: qtwinextras/src/winextras/qwinthumbnailtoolbar.cpp
===================================================================
--- qtwinextras/src/winextras/qwinthumbnailtoolbar.cpp	(revision 1785)
+++ qtwinextras/src/winextras/qwinthumbnailtoolbar.cpp	(working copy)
@@ -252,11 +252,13 @@
 {
     if (!pTbList || !window)
         return;
+#if 0
     THUMBBUTTON buttons[windowsLimitedThumbbarSize];
     initButtons(buttons);
     HRESULT hresult = pTbList->ThumbBarAddButtons(reinterpret_cast<HWND>(window->winId()), windowsLimitedThumbbarSize, buttons);
     if (FAILED(hresult))
         qWarning() << msgComFailed("ThumbBarAddButtons", hresult);
+#endif
 }
 
 void QWinThumbnailToolBarPrivate::clearToolbar()
@@ -319,6 +321,7 @@
 bool QWinThumbnailToolBarPrivate::nativeEventFilter(const QByteArray &, void *message, long *result)
 {
     MSG *msg = static_cast<MSG *>(message);
+#if 0
     if (window && msg->message == WM_COMMAND && HIWORD(msg->wParam) == THBN_CLICKED && msg->hwnd == reinterpret_cast<HWND>(window->winId())) {
         int buttonId = LOWORD(msg->wParam);
         buttonId = buttonId - (windowsLimitedThumbbarSize - qMin(windowsLimitedThumbbarSize, buttonList.size()));
@@ -327,6 +330,7 @@
             *result = 0;
         return true;
     }
+#endif
     return false;
 }
 
@@ -343,6 +347,7 @@
 THUMBBUTTONFLAGS QWinThumbnailToolBarPrivate::makeNativeButtonFlags(const QWinThumbnailToolButton *button)
 {
     THUMBBUTTONFLAGS nativeFlags = (THUMBBUTTONFLAGS)0;
+ #if 0
     if (button->isEnabled())
         nativeFlags |= THBF_ENABLED;
     else
@@ -355,6 +360,7 @@
         nativeFlags |= THBF_HIDDEN;
     if (!button->isInteractive())
         nativeFlags |= THBF_NONINTERACTIVE;
+#endif
     return nativeFlags;
 }
 
@@ -361,11 +367,13 @@
 THUMBBUTTONMASK QWinThumbnailToolBarPrivate::makeButtonMask(const QWinThumbnailToolButton *button)
 {
     THUMBBUTTONMASK mask = (THUMBBUTTONMASK)0;
+#if 0
     mask |= THB_FLAGS;
     if (!button->icon().isNull())
         mask |= THB_ICON;
     if (!button->toolTip().isEmpty())
         mask |= THB_TOOLTIP;
+#endif
     return mask;
 }
 

_______________________________________________
Interest mailing list
Interest@qt-project.org
http://lists.qt-project.org/mailman/listinfo/interest